github-vet / github-vet/rangeloop-pointer-findings
grafana/metrictank: idx/memory/partitioned_idx.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [grafana/metrictank](https://www.github.com/grafana/metrictank) at [idx/memory/partitioned_idx.go](https://github.com/grafana/metrictank/blob/64e50d7bc54b4ee594ced278703535b9e6a1d7e0/idx/memory/partitioned_idx.go#L196-L209)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to node is reassigned at line 199
[Click here to see the code in its original context.](https://github.com/grafana/metrictank/blob/64e50d7bc54b4ee594ced278703535b9e6a1d7e0/idx/memory/partitioned_idx.go#L196-L209)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for _, node := range found {
n, ok := byPath[node.Path]
if !ok {
byPath[node.Path] = &node
} else {
if node.HasChildren {
n.HasChildren = true
}
if node.Leaf {
n.Defs = append(n.Defs, node.Defs...)
n.Leaf = true
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 64e50d7bc54b4ee594ced278703535b9e6a1d7e0
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.