github-vet / github-vet/rangeloop-pointer-findings

matijavizintin/effective-go: closure/closure.go; 9 LoC

Open
#13,768 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [matijavizintin/effective-go](https://www.github.com/matijavizintin/effective-go) at [closure/closure.go](https://github.com/matijavizintin/effective-go/blob/f9991fae3dda3dff7522e1f46bc19c6510a2a30b/closure/closure.go#L12-L20)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable req used in defer or goroutine at line 17

[Click here to see the code in its original context.](https://github.com/matijavizintin/effective-go/blob/f9991fae3dda3dff7522e1f46bc19c6510a2a30b/closure/closure.go#L12-L20)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for req := range queue {
sem <- 1
go func() {
// NOTE: in this case req variable will be shared across all request due to closures - this is a bug
// we don't want that
process(req)
<-sem
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f9991fae3dda3dff7522e1f46bc19c6510a2a30b

Contributor guide

No contributing guide indexed for this repository

Research direction

Read closure/closure.go at the referenced commit and inspect the loop around lines 12–20, including the goroutine calling process(req). Decide whether sharing the range variable creates a real bug in this example, then classify the finding with the requested reaction as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.