github-vet / github-vet/rangeloop-pointer-findings

cavaliercoder/nugo: repo.go; 25 LoC

Open
#13,750 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [cavaliercoder/nugo](https://www.github.com/cavaliercoder/nugo) at [repo.go](https://github.com/cavaliercoder/nugo/blob/cc388afeb547320670846d3af240d947cbebfa76/repo.go#L139-L163)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/cavaliercoder/nugo/blob/cc388afeb547320670846d3af240d947cbebfa76/repo.go#L139-L163)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for _, p := range c.packages {
skip := skipByDefault

// filter by ID
if params.ByID != "" && (strings.ToLower(p.Manifest.ID) == strings.ToLower(params.ByID)) {
LogDebugf("Package matches ID: %s", &p)
skip = false
}

// filter by term
if params.SearchTerm != "" && stringInString(params.SearchTerm, p.Manifest.ID, p.Manifest.Tags, p.Manifest.Description) {
LogDebugf("Package matches search term: %s", &p)
skip = false
}

// filter by latest only
if params.Filter.LatestOnly && !p.IsLatest {
LogDebugf("Package is superceded: %s", &p)
skip = true
}

if !skip {
out = append(out, p)
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {LogDebugf 2} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: cc388afeb547320670846d3af240d947cbebfa76

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the referenced repo.go lines 139-163 in cavaliercoder/nugo and inspect the surrounding repository logic. Start by understanding the analyzer finding and the use of the range variable in the shown loop; done means classifying the finding as Bug, Mitigated, or Desirable Behavior with a reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.