github-vet / github-vet/rangeloop-pointer-findings

ribasushi/ltsh: extern/storage-sealing/fsm.go; 38 LoC

Open
#13,708 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ribasushi/ltsh](https://www.github.com/ribasushi/ltsh) at [extern/storage-sealing/fsm.go](https://github.com/ribasushi/ltsh/blob/5b5ae9759be7d12064e0bcd3696911cffd4a1be0/extern/storage-sealing/fsm.go#L410-L447)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable sector used in defer or goroutine at line 441

[Click here to see the code in its original context.](https://github.com/ribasushi/ltsh/blob/5b5ae9759be7d12064e0bcd3696911cffd4a1be0/extern/storage-sealing/fsm.go#L410-L447)

Click here to show the 38 line(s) of Go which triggered the analyzer.

```go
for _, sector := range trackedSectors {
if err := m.sectors.Send(uint64(sector.SectorNumber), SectorRestart{}); err != nil {
log.Errorf("restarting sector %d: %+v", sector.SectorNumber, err)
}

if sector.State == WaitDeals {

// put the sector in the unsealedInfoMap
if _, ok := m.unsealedInfoMap.infos[sector.SectorNumber]; ok {
// something's funky here, but probably safe to move on
log.Warnf("sector %v was already in the unsealedInfoMap when restarting", sector.SectorNumber)
} else {
ui := UnsealedSectorInfo{
ssize: ssize,
}
for _, p := range sector.Pieces {
if p.DealInfo != nil {
ui.numDeals++
}
ui.stored += p.Piece.Size
ui.pieceSizes = append(ui.pieceSizes, p.Piece.Size.Unpadded())
}

m.unsealedInfoMap.infos[sector.SectorNumber] = ui
}

// start a fresh timer for the sector
if cfg.WaitDealsDelay > 0 {
timer := time.NewTimer(cfg.WaitDealsDelay)
go func() {
<-timer.C
if err := m.StartPacking(sector.SectorNumber); err != nil {
log.Errorf("starting sector %d: %+v", sector.SectorNumber, err)
}
}()
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 5b5ae9759be7d12064e0bcd3696911cffd4a1be0

Contributor guide

No contributing guide indexed for this repository

Research direction

Read extern/storage-sealing/fsm.go around lines 410-447, especially the goroutine at line 441 and its use of the range variable sector. Determine whether the goroutine can use the wrong sector when it starts, then classify the finding as a bug, mitigated, or desirable behavior as requested by the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.