github-vet / github-vet/rangeloop-pointer-findings

Azure/azure-service-operator: pkg/resourcemanager/pip/client.go; 6 LoC

Open
#13,688 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Azure/azure-service-operator](https://www.github.com/Azure/azure-service-operator) at [pkg/resourcemanager/pip/client.go](https://github.com/Azure/azure-service-operator/blob/0c2ad1589ddb9a1e4e7469a6afe7118e6988b53a/pkg/resourcemanager/pip/client.go#L92-L97)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to k was used in a composite literal at line 94

[Click here to see the code in its original context.](https://github.com/Azure/azure-service-operator/blob/0c2ad1589ddb9a1e4e7469a6afe7118e6988b53a/pkg/resourcemanager/pip/client.go#L92-L97)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for k, v := range tags {
outputTags = append(outputTags, vnetwork.IPTag{
IPTagType: &k,
Tag: &v,
})
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0c2ad1589ddb9a1e4e7469a6afe7118e6988b53a

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in pkg/resourcemanager/pip/client.go around lines 92-97 and read the surrounding tag conversion code. Verify the analyzer's report about references to the range variables, then inspect any existing tests for this client; done means the finding is addressed and the tag conversion remains covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.