github-vet / github-vet/rangeloop-pointer-findings

dongjun111111/notes: 工具/downBinlog.go; 14 LoC

Open
#13,672 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [dongjun111111/notes](https://www.github.com/dongjun111111/notes) at [工具/downBinlog.go](https://github.com/dongjun111111/notes/blob/4a3f7a1244497f9bacbfb4eb621c5b9db074b569/工具/downBinlog.go#L246-L259)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable k used in defer or goroutine at line 248

[Click here to see the code in its original context.](https://github.com/dongjun111111/notes/blob/4a3f7a1244497f9bacbfb4eb621c5b9db074b569/工具/downBinlog.go#L246-L259)

Click here to show the 14 line(s) of Go which triggered the analyzer.

```go
for k, v := range *dLoads {
go func() {
i := k
//单个下载
name, err := downOne(v, path+"/"+dir, i, record)
if err != nil {
ch <- err
} else {
ch <- nil
*names = append(*names, name)
}
}()
time.Sleep(time.Microsecond)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 4a3f7a1244497f9bacbfb4eb621c5b9db074b569

Contributor guide

No contributing guide indexed for this repository

Research direction

Read 工具/downBinlog.go at lines 246-259 and compare the goroutine's range-variable use with the analyzer guidance linked in the issue. Leave a reaction marking the finding as Bug, Mitigated, or Desirable Behavior; completion is the selected classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.