scaleway/terraform-provider-scaleway: scaleway/resource_instance_security_group.go; 65 LoC

Found a possible issue in [scaleway/terraform-provider-scaleway](https://www.github.com/scaleway/terraform-provider-scaleway) at [scaleway/resource_instance_security_group.go](https://github.com/scaleway/terraform-provider-scaleway/blob/607e5d091c4ed1f5e92e5e1b62269550b1d6d951/scaleway/resource_instance_security_group.go#L305-L369)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to direction was used in a composite literal at line 350

[Click here to see the code in its original context.](https://github.com/scaleway/terraform-provider-scaleway/blob/607e5d091c4ed1f5e92e5e1b62269550b1d6d951/scaleway/resource_instance_security_group.go#L305-L369)

Click here to show the 65 line(s) of Go which triggered the analyzer.

```go
for direction := range stateRules {
// Loop for all state rules in this direction
for index, rawStateRule := range stateRules[direction] {
apiRule := (*instance.SecurityGroupRule)(nil)
stateRule := securityGroupRuleExpand(rawStateRule)

// This happen when there is more rule in state than in the api. We create more rule in API.
if index >= len(apiRules[direction]) {
_, err = instanceAPI.CreateSecurityGroupRule(&instance.CreateSecurityGroupRuleRequest{
Zone: zone,
SecurityGroupID: securityGroupID,
Protocol: stateRule.Protocol,
IPRange: stateRule.IPRange,
Action: stateRule.Action,
DestPortTo: stateRule.DestPortTo,
DestPortFrom: stateRule.DestPortFrom,
Direction: direction,
}, scw.WithContext(ctx))
if err != nil {
return err
}
continue
}

// We compare rule stateRule[index] and apiRule[index]. If they are different we update api rule to match state.
apiRule = apiRules[direction][index]
if !securityGroupRuleEquals(stateRule, apiRule) {
destPortFrom := stateRule.DestPortFrom
destPortTo := stateRule.DestPortTo
if destPortFrom == nil {
destPortFrom = scw.Uint32Ptr(0)
}
if destPortTo == nil {
destPortTo = scw.Uint32Ptr(0)
}

_, err = instanceAPI.UpdateSecurityGroupRule(&instance.UpdateSecurityGroupRuleRequest{
Zone: zone,
SecurityGroupID: securityGroupID,
SecurityGroupRuleID: apiRule.ID,
Protocol: &stateRule.Protocol,
IPRange: &stateRule.IPRange,
Action: &stateRule.Action,
DestPortTo: destPortTo,
DestPortFrom: destPortFrom,
Direction: &direction,
}, scw.WithContext(ctx))
if err != nil {
return err
}
}
}

// We loop through remaining API rules and delete them as they are no longer in the state.
for index := len(stateRules[direction]); index < len(apiRules[direction]); index++ {
err = instanceAPI.DeleteSecurityGroupRule(&instance.DeleteSecurityGroupRuleRequest{
Zone: zone,
SecurityGroupID: securityGroupID,
SecurityGroupRuleID: apiRules[direction][index].ID,
}, scw.WithContext(ctx))
if err != nil {
return err
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 607e5d091c4ed1f5e92e5e1b62269550b1d6d951