github-vet / github-vet/rangeloop-pointer-findings

mgechev/revive: testdata/range-val-in-closure.go; 5 LoC

Open
#13,665 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [mgechev/revive](https://www.github.com/mgechev/revive) at [testdata/range-val-in-closure.go](https://github.com/mgechev/revive/blob/80884d48fd59e0c4d2a574212cd27356d577d4c0/testdata/range-val-in-closure.go#L25-L29)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 27

[Click here to see the code in its original context.](https://github.com/mgechev/revive/blob/80884d48fd59e0c4d2a574212cd27356d577d4c0/testdata/range-val-in-closure.go#L25-L29)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for i, newg := range groups {
go func(newg int) {
newg.run(m.opts.Context,i) // MATCH /loop variable i captured by func literal/
}(newg)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 80884d48fd59e0c4d2a574212cd27356d577d4c0

Contributor guide

No contributing guide indexed for this repository

Research direction

Read testdata/range-val-in-closure.go at lines 25-29 and review how the range variable i is used inside the goroutine. Run the analyzer on this snippet if the project is available; done means deciding whether the finding is a Bug, Mitigated, or Desirable Behavior and leaving the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.