github-vet / github-vet/rangeloop-pointer-findings

ysugimoto/ginger: command/builder.go; 23 LoC

Open
#13,608 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ysugimoto/ginger](https://www.github.com/ysugimoto/ginger) at [command/builder.go](https://github.com/ysugimoto/ginger/blob/a97c7d37913748864ba40848c1e3532ca7192b66/command/builder.go#L50-L72)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable fn used in defer or goroutine at line 68

[Click here to see the code in its original context.](https://github.com/ysugimoto/ginger/blob/a97c7d37913748864ba40848c1e3532ca7192b66/command/builder.go#L50-L72)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for _, fn := range targets[index:end] {
wg.Add(1)
log.Printf("Building function: %s...\n", fn.Name)
success := make(chan struct{})
err := make(chan error)
go b.compile(fn.Name, success, err)
go func() {
defer func() {
wg.Done()
close(success)
close(err)
}()
select {
case e := <-err:
log.Errorf("Failed to build function: %s\n", e.Error())
errorBuilds = append(errorBuilds, e)
return
case <-success:
log.Infof("Function %s built successfully\n", fn.Name)
return
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: a97c7d37913748864ba40848c1e3532ca7192b66

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.