github-vet / github-vet/rangeloop-pointer-findings

redhat-cop/global-load-balancer-operator: pkg/apis/redhatcop/v1alpha1/zz_generated.deepcopy.go; 13 LoC

Open
#13,601 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [redhat-cop/global-load-balancer-operator](https://www.github.com/redhat-cop/global-load-balancer-operator) at [pkg/apis/redhatcop/v1alpha1/zz_generated.deepcopy.go](https://github.com/redhat-cop/global-load-balancer-operator/blob/55324931779895ff98b90109bec84a1a7d9e7f44/pkg/apis/redhatcop/v1alpha1/zz_generated.deepcopy.go#L172-L184)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 177

[Click here to see the code in its original context.](https://github.com/redhat-cop/global-load-balancer-operator/blob/55324931779895ff98b90109bec84a1a7d9e7f44/pkg/apis/redhatcop/v1alpha1/zz_generated.deepcopy.go#L172-L184)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal []status.Condition
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(status.Conditions, len(*in))
for i := range *in {
(*in)[i].DeepCopyInto(&(*out)[i])
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 55324931779895ff98b90109bec84a1a7d9e7f44

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the linked range-loop snippet in pkg/apis/redhatcop/v1alpha1/zz_generated.deepcopy.go and review the surrounding generated deepcopy code. Compare the analyzer finding with the linked classification guidance, then leave the reaction that best matches whether this is a Bug, Mitigated finding, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.