github-vet / github-vet/rangeloop-pointer-findings
0xef53/go-qmp: event_buffer.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [0xef53/go-qmp](https://www.github.com/0xef53/go-qmp) at [event_buffer.go](https://github.com/0xef53/go-qmp/blob/17ed9ec80b2d8356f189c764d16474d948aef009/event_buffer.go#L148-L150)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/0xef53/go-qmp/blob/17ed9ec80b2d8356f189c764d16474d948aef009/event_buffer.go#L148-L150)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, e := range ee {
append(&e)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {append 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 17ed9ec80b2d8356f189c764d16474d948aef009
Contributor guide
No contributing guide indexed for this repository
Research direction
Review event_buffer.go lines 148-150 and the linked commit context; first determine whether taking &e inside the range loop creates the reported pointer-capture problem. Compare the finding with the repository's classification guidance, then leave the appropriate Bug, Mitigated, or Desirable Behavior reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100