openshift/pagerduty-operator: pkg/controller/pagerdutyintegration/pagerdutyintegration_controller.go; 29 LoC

Found a possible issue in [openshift/pagerduty-operator](https://www.github.com/openshift/pagerduty-operator) at [pkg/controller/pagerdutyintegration/pagerdutyintegration_controller.go](https://github.com/openshift/pagerduty-operator/blob/24fd6e156f27be3cc62aee5139cd621040dcd9c2/pkg/controller/pagerdutyintegration/pagerdutyintegration_controller.go#L250-L278)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/openshift/pagerduty-operator/blob/24fd6e156f27be3cc62aee5139cd621040dcd9c2/pkg/controller/pagerdutyintegration/pagerdutyintegration_controller.go#L250-L278)

Click here to show the 29 line(s) of Go which triggered the analyzer.

```go
for _, cd := range allClusterDeployments.Items {
if utils.HasFinalizer(&cd, clusterDeploymentFinalizerName) {
if cd.DeletionTimestamp != nil {
// it has a finalizer and is being deleted. clean up PD things!
err := r.handleDelete(pdClient, pdi, &cd)
if err != nil {
return r.requeueOnErr(err)
}
} else {
// it has a finalizer and is NOT being deleted.
// check if it should have PD setup or not (did it drop out of the PDI?)
cdIsMatching := false
for _, mcd := range matchingClusterDeployments.Items {
if cd.Namespace == mcd.Namespace && cd.Name == mcd.Name {
cdIsMatching = true
break
}
}

if !cdIsMatching {
// the CD has a finalizer but is NOT matching the PDI. clean it up.
err := r.handleDelete(pdClient, pdi, &cd)
if err != nil {
return r.requeueOnErr(err)
}
}
}
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {HasFinalizer 2} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 24fd6e156f27be3cc62aee5139cd621040dcd9c2

Read pkg/controller/pagerdutyintegration/pagerdutyintegration_controller.go around lines 250-278, then inspect the shown HasFinalizer and handleDelete calls to determine whether the range variable’s pointer can escape. Confirm whether the analyzer finding represents a real bug, mitigated behavior, or desirable behavior, and leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.