github-vet / github-vet/rangeloop-pointer-findings

gentoo/soko: pkg/portage/github/pullrequests.go; 25 LoC

Open
#13,579 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gentoo/soko](https://www.github.com/gentoo/soko) at [pkg/portage/github/pullrequests.go](https://github.com/gentoo/soko/blob/bf33f10b9eb13d07346f1a79ae0695d4f6beb0ed/pkg/portage/github/pullrequests.go#L158-L182)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/gentoo/soko/blob/bf33f10b9eb13d07346f1a79ae0695d4f6beb0ed/pkg/portage/github/pullrequests.go#L158-L182)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for _, pullrequest := range pullrequests {
//
// Create Pullrequest
//
database.DBCon.Model(&pullrequest).WherePK().OnConflict("(id) DO UPDATE").Insert()

//
// Create Package To Pullrequest
//
var affectedPackages []string
for _, file := range pullrequest.Files {
pathParts := strings.Split(file.Path, "/")
if len(pathParts) >= 2 && strings.Contains(pathParts[0], "-") {
affectedPackages = append(affectedPackages, pathParts[0]+"/"+pathParts[1])
}
}
affectedPackages = utils.Deduplicate(affectedPackages)
for _, affectedPackage := range affectedPackages {
database.DBCon.Model(&models.PackageToGithubPullRequest{
Id: affectedPackage + "-" + pullrequest.Id,
PackageAtom: affectedPackage,
GithubPullRequestId: pullrequest.Id,
}).WherePK().OnConflict("(id) DO UPDATE").Insert()
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Model 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bf33f10b9eb13d07346f1a79ae0695d4f6beb0ed

Contributor guide

No contributing guide indexed for this repository

Research direction

Read pkg/portage/github/pullrequests.go around lines 158-182 at commit bf33f10b9eb13d07346f1a79ae0695d4f6beb0ed, then review the analyzer details and surrounding pull-request persistence code. Determine whether the reported range-loop usage is a bug, mitigated, or desirable behavior, and leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.