github-vet / github-vet/rangeloop-pointer-findings

84KaliPleXon3/lxd: lxd/cluster/membership.go; 5 LoC

Open
#13,537 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [84KaliPleXon3/lxd](https://www.github.com/84KaliPleXon3/lxd) at [lxd/cluster/membership.go](https://github.com/84KaliPleXon3/lxd/blob/49f7de5a4d013be4b41eea68ea82e491508b2561/lxd/cluster/membership.go#L333-L337)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to node is reassigned at line 335

[Click here to see the code in its original context.](https://github.com/84KaliPleXon3/lxd/blob/49f7de5a4d013be4b41eea68ea82e491508b2561/lxd/cluster/membership.go#L333-L337)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, node := range raftNodes {
if node.Address == address {
info = &node
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 49f7de5a4d013be4b41eea68ea82e491508b2561

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading lxd/cluster/membership.go around lines 333-337 and the surrounding function, then check the Go range-loop pointer behavior involved in the analyzer finding. Confirm whether the matching node information remains valid after the loop; done means the finding is classified as a bug, mitigated, or desirable behavior with the result reflected in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.