github-vet / github-vet/rangeloop-pointer-findings
giagiannis/data-profiler: data-profiler-utils/exp-ordering.go; 104 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [giagiannis/data-profiler](https://www.github.com/giagiannis/data-profiler) at [data-profiler-utils/exp-ordering.go](https://github.com/giagiannis/data-profiler/blob/a64327652e682380fa05452314856382a08edc5e/data-profiler-utils/exp-ordering.go#L242-L345)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable sr used in defer or goroutine at line 255
[Click here to see the code in its original context.](https://github.com/giagiannis/data-profiler/blob/a64327652e682380fa05452314856382a08edc5e/data-profiler-utils/exp-ordering.go#L242-L345)
Click here to show the 104 line(s) of Go which triggered the analyzer.
```go
for _, sr := range params.samplingRates {
resultsRho, resultsTau, resultsTop10, resultsTop25, resultsTop50 :=
make([]float64, 0), make([]float64, 0), make([]float64, 0), make([]float64, 0), make([]float64, 0)
resultsTop2Perc, resultsTop5Perc, resultsTop10Perc, resultsTop25Perc, resultsTop50Perc :=
make([]float64, 0), make([]float64, 0), make([]float64, 0), make([]float64, 0), make([]float64, 0)
done := make(chan *evalResults)
slots := make(chan bool, *params.threads)
for i := 0; i < *params.threads; i++ {
slots <- true
}
for i := 0; i < *params.repetitions; i++ {
go func(done chan *evalResults, slots chan bool, repetition int) {
log.Printf("[thread-%d] Starting calculation for SR %.2f\n", repetition, sr)
<-slots
done <- eval(sr)
slots <- true
log.Printf("[thread-%d] Done calculation for SR %.2f\n", repetition, sr)
}(done, slots, i)
}
for i := 0; i < *params.repetitions; i++ {
v := <-done
resultsTau = append(resultsTau, v.tau)
resultsRho = append(resultsRho, v.rho)
resultsTop10 = append(resultsTop10, v.top10)
resultsTop25 = append(resultsTop25, v.top25)
resultsTop50 = append(resultsTop50, v.top50)
resultsTop2Perc = append(resultsTop2Perc, v.top2Perc)
resultsTop5Perc = append(resultsTop5Perc, v.top5Perc)
resultsTop10Perc = append(resultsTop10Perc, v.top10Perc)
resultsTop25Perc = append(resultsTop25Perc, v.top25Perc)
resultsTop50Perc = append(resultsTop50Perc, v.top50Perc)
}
metricFormat := "%.5f\t%.5f\t%.5f\t%.5f\t%.5f\t%.5f"
format := "%.5f"
for i := 0; i < 10; i++ {
format += "\t" + metricFormat
}
format += "\n"
fmt.Fprintf(output,
format,
sr,
getAverage(resultsTau),
getPercentile(resultsTau, 0),
getPercentile(resultsTau, 25),
getPercentile(resultsTau, 50),
getPercentile(resultsTau, 75),
getPercentile(resultsTau, 100),
getAverage(resultsTop10),
getPercentile(resultsTop10, 0),
getPercentile(resultsTop10, 25),
getPercentile(resultsTop10, 50),
getPercentile(resultsTop10, 75),
getPercentile(resultsTop10, 100),
getAverage(resultsTop25),
getPercentile(resultsTop25, 0),
getPercentile(resultsTop25, 25),
getPercentile(resultsTop25, 50),
getPercentile(resultsTop25, 75),
getPercentile(resultsTop25, 100),
getAverage(resultsTop50),
getPercentile(resultsTop50, 0),
getPercentile(resultsTop50, 25),
getPercentile(resultsTop50, 50),
getPercentile(resultsTop50, 75),
getPercentile(resultsTop50, 100),
getAverage(resultsTop2Perc),
getPercentile(resultsTop2Perc, 0),
getPercentile(resultsTop2Perc, 25),
getPercentile(resultsTop2Perc, 50),
getPercentile(resultsTop2Perc, 75),
getPercentile(resultsTop2Perc, 100),
getAverage(resultsTop5Perc),
getPercentile(resultsTop5Perc, 0),
getPercentile(resultsTop5Perc, 25),
getPercentile(resultsTop5Perc, 50),
getPercentile(resultsTop5Perc, 75),
getPercentile(resultsTop5Perc, 100),
getAverage(resultsTop10Perc),
getPercentile(resultsTop10Perc, 0),
getPercentile(resultsTop10Perc, 25),
getPercentile(resultsTop10Perc, 50),
getPercentile(resultsTop10Perc, 75),
getPercentile(resultsTop10Perc, 100),
getAverage(resultsTop25Perc),
getPercentile(resultsTop25Perc, 0),
getPercentile(resultsTop25Perc, 25),
getPercentile(resultsTop25Perc, 50),
getPercentile(resultsTop25Perc, 75),
getPercentile(resultsTop25Perc, 100),
getAverage(resultsTop50Perc),
getPercentile(resultsTop50Perc, 0),
getPercentile(resultsTop50Perc, 25),
getPercentile(resultsTop50Perc, 50),
getPercentile(resultsTop50Perc, 75),
getPercentile(resultsTop50Perc, 100),
getAverage(resultsRho),
getPercentile(resultsRho, 0),
getPercentile(resultsRho, 25),
getPercentile(resultsRho, 50),
getPercentile(resultsRho, 75),
getPercentile(resultsRho, 100),
)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: a64327652e682380fa05452314856382a08edc5e
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.