github-vet / github-vet/rangeloop-pointer-findings

crossplane/provider-aws: apis/apigatewayv2/v1alpha1/zz_generated.deepcopy.go; 11 LoC

Open
#13,507 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [crossplane/provider-aws](https://www.github.com/crossplane/provider-aws) at [apis/apigatewayv2/v1alpha1/zz_generated.deepcopy.go](https://github.com/crossplane/provider-aws/blob/ef58ce6a3340adf1a8217875c18beaafeedd42d1/apis/apigatewayv2/v1alpha1/zz_generated.deepcopy.go#L3114-L3124)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 3119

[Click here to see the code in its original context.](https://github.com/crossplane/provider-aws/blob/ef58ce6a3340adf1a8217875c18beaafeedd42d1/apis/apigatewayv2/v1alpha1/zz_generated.deepcopy.go#L3114-L3124)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal *ParameterConstraints
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = new(ParameterConstraints)
(*in).DeepCopyInto(*out)
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ef58ce6a3340adf1a8217875c18beaafeedd42d1

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect apis/apigatewayv2/v1alpha1/zz_generated.deepcopy.go around lines 3114-3124 and compare the range-loop handling with the surrounding generated deepcopy code. Determine whether the analyzer finding is a Bug, Mitigated, or Desirable Behavior, then record that classification with the corresponding issue reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.