github-vet / github-vet/rangeloop-pointer-findings
Colored-Coins/lnd-cc: htlcswitch.go; 22 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [Colored-Coins/lnd-cc](https://www.github.com/Colored-Coins/lnd-cc) at [htlcswitch.go](https://github.com/Colored-Coins/lnd-cc/blob/804e9ac7a26e0b87ba7ded1bbc117fcfd45bc53c/htlcswitch.go#L175-L196)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable link used in defer or goroutine at line 189
[Click here to see the code in its original context.](https://github.com/Colored-Coins/lnd-cc/blob/804e9ac7a26e0b87ba7ded1bbc117fcfd45bc53c/htlcswitch.go#L175-L196)
Click here to show the 22 line(s) of Go which triggered the analyzer.
```go
for _, link := range chanInterface {
// TODO(roasbeef): implement HTLC fragmentation
// * avoid full channel depletion at higher
// level (here) instead of within state
// machine?
if link.availableBandwidth < amt {
continue
}
hswcLog.Tracef("Sending %v to %x", amt, dest[:])
// TODO(roasbeef): peer downstream should set chanPoint
wireMsg.ChannelPoint = link.chanPoint
go func() {
link.linkChan <- htlcPkt
}()
// TODO(roasbeef): update link info on
// timeout/settle
link.availableBandwidth -= amt
sent = true
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 804e9ac7a26e0b87ba7ded1bbc117fcfd45bc53c
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.