github-vet / github-vet/rangeloop-pointer-findings
wantedly/webmock-proxy: webmock/cache.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [wantedly/webmock-proxy](https://www.github.com/wantedly/webmock-proxy) at [webmock/cache.go](https://github.com/wantedly/webmock-proxy/blob/270826ab55e2aa3c94e2f4b4a42a6d0121c4d21f/webmock/cache.go#L47-L53)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/wantedly/webmock-proxy/blob/270826ab55e2aa3c94e2f4b4a42a6d0121c4d21f/webmock/cache.go#L47-L53)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for _, v := range ce.Connections {
deleteConnection(&v, s.db)
if v.Request.Method == req.Method {
continue
}
conns = append(conns, v)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {deleteConnection 2} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 270826ab55e2aa3c94e2f4b4a42a6d0121c4d21f
Contributor guide
No contributing guide indexed for this repository
Research direction
Read webmock/cache.go at lines 47-53 and review the linked code context, focusing on how the range variable v is passed to deleteConnection. Compare the behavior with the analyzer details, then leave the appropriate Bug, Mitigated, or Desirable Behavior reaction; completion is the classification reaction itself.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100