github-vet / github-vet/rangeloop-pointer-findings
aliyun/aliyun-tablestore-go-sdk: timeline/promise/future.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [aliyun/aliyun-tablestore-go-sdk](https://www.github.com/aliyun/aliyun-tablestore-go-sdk) at [timeline/promise/future.go](https://github.com/aliyun/aliyun-tablestore-go-sdk/blob/d0b74d30ea58768f981d5e19dc6a7d375a2fe6b0/timeline/promise/future.go#L56-L62)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable f used in defer or goroutine at line 59
[Click here to see the code in its original context.](https://github.com/aliyun/aliyun-tablestore-go-sdk/blob/d0b74d30ea58768f981d5e19dc6a7d375a2fe6b0/timeline/promise/future.go#L56-L62)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for i, f := range futures {
go func(idx int) {
defer wg.Done()
ret, err := f.Get()
fanResults[idx] = &FanResult{Result: ret, Err: err}
}(i)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: d0b74d30ea58768f981d5e19dc6a7d375a2fe6b0
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with timeline/promise/future.go at lines 56-62 and inspect how the goroutine uses the range-loop variable f while collecting fanResults. Confirm whether the analyzer warning can affect the intended result mapping, then check the repository's available Go tests or validation commands. Done means the reported warning is addressed without changing the expected future results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100