github-vet / github-vet/rangeloop-pointer-findings

kojhliang/kkchain: p2p/dht/dht.go; 5 LoC

Open
#13,437 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kojhliang/kkchain](https://www.github.com/kojhliang/kkchain) at [p2p/dht/dht.go](https://github.com/kojhliang/kkchain/blob/79fd6de87b08520de4c17083f2bb978272c15709/p2p/dht/dht.go#L299-L303)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/kojhliang/kkchain/blob/79fd6de87b08520de4c17083f2bb978272c15709/p2p/dht/dht.go#L299-L303)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, v := range peers {
if now.Sub(v.addTime) > DefaultSeedMinTableTime {
dht.store.Update(&v)
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Update 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 79fd6de87b08520de4c17083f2bb978272c15709

Contributor guide

No contributing guide indexed for this repository

Research direction

Read p2p/dht/dht.go around lines 299-303, then inspect the referenced Update call and the analyzer context. Decide whether the reported range-loop pointer behavior is a bug, mitigated, or desirable behavior, and record the appropriate classification reaction; no code change or test is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems, networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.