github-vet / github-vet/rangeloop-pointer-findings

jpincas/tormenta: get.go; 20 LoC

Open
#13,434 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [jpincas/tormenta](https://www.github.com/jpincas/tormenta) at [get.go](https://github.com/jpincas/tormenta/blob/318d2c1e7b38f254839aaa9f19df6609f5381a46/get.go#L54-L73)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable id used in defer or goroutine at line 67

[Click here to see the code in its original context.](https://github.com/jpincas/tormenta/blob/318d2c1e7b38f254839aaa9f19df6609f5381a46/get.go#L54-L73)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, id := range ids {
wg.Add(1)

// It's inefficient creating a new entity target for the result
// on every loop, but we can't just create a single one
// and reuse it, because there would be risk of data from 'previous'
// entities 'infecting' later ones if a certain field wasn't present
// in that later entity, but was in the previous one.
// Unlikely if the all JSON is saved with the schema, but I don't
// think we can risk it
go func(thisRecord Record, thisID gouuidv6.UUID) {
found, err := db.get(txn, thisRecord, ctx, thisID)
ch <- getResult{
id: thisID,
record: thisRecord,
found: found,
err: err,
}
}(newRecordFromSlice(target), id)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 318d2c1e7b38f254839aaa9f19df6609f5381a46

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.