github-vet / github-vet/rangeloop-pointer-findings

eBay/collectbeat: discoverer/kubernetes/kubernetes.go; 3 LoC

Open
#13,431 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [eBay/collectbeat](https://www.github.com/eBay/collectbeat) at [discoverer/kubernetes/kubernetes.go](https://github.com/eBay/collectbeat/blob/0b4a972214f8f2eee75494b87b3116feeebd2e2d/discoverer/kubernetes/kubernetes.go#L55-L57)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to cfg was used in a composite literal at line 56

[Click here to see the code in its original context.](https://github.com/eBay/collectbeat/blob/0b4a972214f8f2eee75494b87b3116feeebd2e2d/discoverer/kubernetes/kubernetes.go#L55-L57)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for key, cfg := range registry.BuilderRegistry.GetDefaultBuilderConfigs() {
config.Builders = append(config.Builders, map[string]*common.Config{key: &cfg})
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0b4a972214f8f2eee75494b87b3116feeebd2e2d

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect discoverer/kubernetes/kubernetes.go at lines 55-57, then review the surrounding builder configuration and the analyzer's range-loop finding. Determine whether the reported reference is a bug, mitigated, or desirable behavior, and leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.