github-vet / github-vet/rangeloop-pointer-findings

influx6/tlsfs: scripts/letsencrypt/boulder/test/authz-filler/main.go; 19 LoC

Open
#13,421 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [influx6/tlsfs](https://www.github.com/influx6/tlsfs) at [scripts/letsencrypt/boulder/test/authz-filler/main.go](https://github.com/influx6/tlsfs/blob/49c59472132e16b94e1711bfafa97cae10e5ef79/scripts/letsencrypt/boulder/test/authz-filler/main.go#L72-L90)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to expires was used in a composite literal at line 77

[Click here to see the code in its original context.](https://github.com/influx6/tlsfs/blob/49c59472132e16b94e1711bfafa97cae10e5ef79/scripts/letsencrypt/boulder/test/authz-filler/main.go#L72-L90)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for expires := range work {
err = dbMap.Insert(&model{
core.Authorization{
ID: core.NewToken(),
RegistrationID: 1,
Expires: &expires,
Combinations: [][]int{[]int{1, 2, 3}},
Status: "pending",
Identifier: core.AcmeIdentifier{
Type: "dns",
Value: "example.com",
},
},
0,
})
if err != nil {
log.Print(err)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 49c59472132e16b94e1711bfafa97cae10e5ef79

Contributor guide

No contributing guide indexed for this repository

Research direction

Read scripts/letsencrypt/boulder/test/authz-filler/main.go at the referenced commit, beginning with the 19-line snippet around lines 72–90. Compare the analyzer finding with the surrounding test helper and the range-loop finding guidance. Done means deciding whether the finding is a Bug, Mitigated, or Desirable Behavior and applying the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.