github-vet / github-vet/rangeloop-pointer-findings

synw/centcli: libcentcli/cmd/stats/stats.go; 10 LoC

Open
#13,416 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [synw/centcli](https://www.github.com/synw/centcli) at [libcentcli/cmd/stats/stats.go](https://github.com/synw/centcli/blob/1549af168f11a7b8e67d20dd047c864e7cc4b81b/libcentcli/cmd/stats/stats.go#L63-L72)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to node was used in a composite literal at line 64

[Click here to see the code in its original context.](https://github.com/synw/centcli/blob/1549af168f11a7b8e67d20dd047c864e7cc4b81b/libcentcli/cmd/stats/stats.go#L63-L72)

Click here to show the 10 line(s) of Go which triggered the analyzer.

```go
for _, node := range stats.Nodes {
msg := msgForNode(&node)
ctx.Println(msg)
nmsg, trace := getStat(&node, stat)
if trace != nil {
ctx.Println(trace.Formatc())
return
}
ctx.Println(nmsg)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1549af168f11a7b8e67d20dd047c864e7cc4b81b

Contributor guide

No contributing guide indexed for this repository

Research direction

Open libcentcli/cmd/stats/stats.go at lines 63-72 and inspect the range loop and the two calls receiving &node. Compare the analyzer finding with the surrounding stats command and the linked classification guidance, then leave the requested Bug, Mitigated, or Desirable Behavior reaction; done means providing one supported classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.