github-vet / github-vet/rangeloop-pointer-findings

GoogleContainerTools/container-structure-test: pkg/types/v2/structure.go; 32 LoC

Open
#13,371 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [GoogleContainerTools/container-structure-test](https://www.github.com/GoogleContainerTools/container-structure-test) at [pkg/types/v2/structure.go](https://github.com/GoogleContainerTools/container-structure-test/blob/406fa03fd5add66281c2d5fce9e5dbd290bb5ec8/pkg/types/v2/structure.go#L63-L94)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable test used in defer or goroutine at line 89

[Click here to see the code in its original context.](https://github.com/GoogleContainerTools/container-structure-test/blob/406fa03fd5add66281c2d5fce9e5dbd290bb5ec8/pkg/types/v2/structure.go#L63-L94)

Click here to show the 32 line(s) of Go which triggered the analyzer.

```go
for _, test := range st.CommandTests {
if !test.Validate(channel) {
continue
}
res := &types.TestResult{
Name: test.Name,
Pass: false,
}
driver, err := st.NewDriver()
if err != nil {
res.Errorf("error creating driver: %s", err.Error())
channel <- res
continue
}
defer driver.Destroy()
if err = driver.SetEnv(st.GlobalEnvVars); err != nil {
res.Errorf("error setting env vars: %s", err.Error())
channel <- res
continue
}
if err = driver.Setup(test.EnvVars, test.Setup); err != nil {
res.Errorf("error in setup: %s", err.Error())
channel <- res
continue
}
defer func() {
if err := driver.Teardown(test.Teardown); err != nil {
logrus.Error(err.Error())
}
}()
channel <- test.Run(driver)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 406fa03fd5add66281c2d5fce9e5dbd290bb5ec8

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with pkg/types/v2/structure.go around lines 63-94 and inspect the deferred calls inside the CommandTests loop, focusing on the analyzer warning about the range variable test. Compare the behavior with the linked commit context; done means deciding whether the finding is a Bug, Mitigated, or Desirable Behavior and leaving the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.