github-vet / github-vet/rangeloop-pointer-findings

allermedia/metl: src/job/Job.go; 8 LoC

Open
#13,351 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [allermedia/metl](https://www.github.com/allermedia/metl) at [src/job/Job.go](https://github.com/allermedia/metl/blob/9f0be5ae7c80d8261c6e28ddf9b76c9bf832055d/src/job/Job.go#L318-L325)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable n used in defer or goroutine at line 321

[Click here to see the code in its original context.](https://github.com/allermedia/metl/blob/9f0be5ae7c80d8261c6e28ddf9b76c9bf832055d/src/job/Job.go#L318-L325)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, n := range jf.Notify {
wg.Add(1)
go func() {
log.Infof("Notifying %s", n)
n.Notify(msg)
wg.Done()
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 9f0be5ae7c80d8261c6e28ddf9b76c9bf832055d

Contributor guide

No contributing guide indexed for this repository

Research direction

Read src/job/Job.go at lines 318-325 and inspect the goroutine using the range-loop variable n. Decide whether the analyzer finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.