github-vet / github-vet/rangeloop-pointer-findings

openshift/oc: pkg/cli/image/manifest/manifest.go; 8 LoC

Open
#13,339 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [openshift/oc](https://www.github.com/openshift/oc) at [pkg/cli/image/manifest/manifest.go](https://github.com/openshift/oc/blob/8fbc95fdb0e31194797127fd79b891857fed36ac/pkg/cli/image/manifest/manifest.go#L368-L375)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/openshift/oc/blob/8fbc95fdb0e31194797127fd79b891857fed36ac/pkg/cli/image/manifest/manifest.go#L368-L375)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, manifest := range t.Manifests {
if !filterFn(&manifest, len(t.Manifests) > 1) {
klog.V(5).Infof("Skipping image %s for %#v from %s", manifest.Digest, manifest.Platform, ref)
continue
}
klog.V(5).Infof("Including image %s for %#v from %s", manifest.Digest, manifest.Platform, ref)
filtered = append(filtered, manifest)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {filterFn 2} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 8fbc95fdb0e31194797127fd79b891857fed36ac

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with pkg/cli/image/manifest/manifest.go at lines 368-375 and read the surrounding manifest filtering code. Trace filterFn and review the analyzer details to determine whether the pointer to the range variable can affect behavior. Done means deciding whether the finding is a Bug, Mitigated, or Desirable Behavior and leaving the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.