github-vet / github-vet/rangeloop-pointer-findings

sapcc/kubernetes-operators: openstack-seeder/pkg/seeder/apis/v1/types.go; 12 LoC

Open
#13,334 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [sapcc/kubernetes-operators](https://www.github.com/sapcc/kubernetes-operators) at [openstack-seeder/pkg/seeder/apis/v1/types.go](https://github.com/sapcc/kubernetes-operators/blob/2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd/openstack-seeder/pkg/seeder/apis/v1/types.go#L1132-L1143)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/sapcc/kubernetes-operators/blob/2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd/openstack-seeder/pkg/seeder/apis/v1/types.go#L1132-L1143)

Click here to show the 12 line(s) of Go which triggered the analyzer.

```go
for _, v := range e.SubnetPools {
if v.Name == snp.Name {
glog.V(2).Info("merge subnet-pool ", snp)
utils.MergeStructFields(&v, snp)
if len(snp.Prefixes) > 0 {
v.Prefixes = utils.MergeStringSlices(v.Prefixes, snp.Prefixes)
}
found = true
e.SubnetPools[i] = v
break
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {MergeStructFields 2} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd

Contributor guide

No contributing guide indexed for this repository

Research direction

Read openstack-seeder/pkg/seeder/apis/v1/types.go around lines 1132-1143 and inspect the surrounding merge logic, especially the call to utils.MergeStructFields. Determine whether the analyzer finding represents a Bug, Mitigated issue, or Desirable Behavior, then leave the corresponding reaction on this issue; no code change or test is identified in the report.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.