github-vet / github-vet/rangeloop-pointer-findings
sapcc/kubernetes-operators: openstack-seeder/pkg/seeder/apis/v1/types.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [sapcc/kubernetes-operators](https://www.github.com/sapcc/kubernetes-operators) at [openstack-seeder/pkg/seeder/apis/v1/types.go](https://github.com/sapcc/kubernetes-operators/blob/2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd/openstack-seeder/pkg/seeder/apis/v1/types.go#L568-L581)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/sapcc/kubernetes-operators/blob/2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd/openstack-seeder/pkg/seeder/apis/v1/types.go#L568-L581)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for i, s := range e.VolumeTypes {
if s.Name == t.Name {
glog.V(2).Info("merge Cinder volume type ", t)
if s.ExtraSpecs == nil {
s.ExtraSpecs = make(map[string]string)
}
for k, v := range t.ExtraSpecs {
s.ExtraSpecs[k] = v
}
utils.MergeStructFields(&s, t)
e.VolumeTypes[i] = s
return
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {MergeStructFields 2} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 2b57d5e733ae5b07f996c40f20b3faf9fab7e4cd
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with openstack-seeder/pkg/seeder/apis/v1/types.go at lines 568-581 and read the surrounding merge logic. Review the analyzer's range-loop pointer finding and determine whether this code can produce incorrect behavior; done means leaving the appropriate Bug, Mitigated, or Desirable Behavior reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100