aliyun/terraform-provider-alicloud: alicloud/resource_alicloud_ess_scalinggroup.go; 14 LoC

Found a possible issue in [aliyun/terraform-provider-alicloud](https://www.github.com/aliyun/terraform-provider-alicloud) at [alicloud/resource_alicloud_ess_scalinggroup.go](https://github.com/aliyun/terraform-provider-alicloud/blob/2d0eedd4924a16dfa74c94028e9ca130d6c8a2a3/alicloud/resource_alicloud_ess_scalinggroup.go#L452-L465)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to subList is reassigned at line 457

[Click here to see the code in its original context.](https://github.com/aliyun/terraform-provider-alicloud/blob/2d0eedd4924a16dfa74c94028e9ca130d6c8a2a3/alicloud/resource_alicloud_ess_scalinggroup.go#L452-L465)

Click here to show the 14 line(s) of Go which triggered the analyzer.

```go
for _, subList := range subLists {
attachDbInstancesRequest := ess.CreateAttachDBInstancesRequest()
attachDbInstancesRequest.RegionId = client.RegionId
attachDbInstancesRequest.ScalingGroupId = d.Id()
attachDbInstancesRequest.ForceAttach = requests.NewBoolean(true)
attachDbInstancesRequest.DBInstance = &subList
raw, err := client.WithEssClient(func(essClient *ess.Client) (interface{}, error) {
return essClient.AttachDBInstances(attachDbInstancesRequest)
})
if err != nil {
return WrapErrorf(err, DefaultErrorMsg, d.Id(), attachDbInstancesRequest.GetActionName(), AlibabaCloudSdkGoERROR)
}
addDebug(attachDbInstancesRequest.GetActionName(), raw, attachDbInstancesRequest.RpcRequest, attachDbInstancesRequest)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 2d0eedd4924a16dfa74c94028e9ca130d6c8a2a3

Start in alicloud/resource_alicloud_ess_scalinggroup.go at lines 452-465 and review the surrounding scaling-group implementation alongside the analyzer finding. Trace how subList is passed to AttachDBInstances, then determine whether the behavior is a bug, mitigated, or desirable; recording that classification is the completion criterion.

Written by the indexing model from the issue text.