github-vet / github-vet/rangeloop-pointer-findings

DanielPels/eveKillmailCrawler: crawler/crawler.go; 20 LoC

Open
#13,305 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [DanielPels/eveKillmailCrawler](https://www.github.com/DanielPels/eveKillmailCrawler) at [crawler/crawler.go](https://github.com/DanielPels/eveKillmailCrawler/blob/f552da5fa83defab91f76e2be9a6e6e5802df967/crawler/crawler.go#L99-L118)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable system used in defer or goroutine at line 110

[Click here to see the code in its original context.](https://github.com/DanielPels/eveKillmailCrawler/blob/f552da5fa83defab91f76e2be9a6e6e5802df967/crawler/crawler.go#L99-L118)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, system := range z.queue {
//check if we have a last kill
if system.LastKill != nil {
//if we do then check if we have passed this time
if hasTimePast(*system.LastKill, z.finishTime) {
//true == past time continue to next for loop
continue
}
}
//create new go routine to request systems
go func() {
if system.LastKill != nil {
z.getKillmails(system.Id, system.LastKill.Format("2006010215")+"00")
} else {
z.getKillmails(system.Id, "")
}
}()
//break the loop to only request 1 system per tick
break
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f552da5fa83defab91f76e2be9a6e6e5802df967

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.