github-vet / github-vet/rangeloop-pointer-findings

ASeegull/SmartFridge: server/database/postgres.go; 36 LoC

Open
#13,284 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ASeegull/SmartFridge](https://www.github.com/ASeegull/SmartFridge) at [server/database/postgres.go](https://github.com/ASeegull/SmartFridge/blob/5154e44b87d5023ed26c645001b696b1212baebc/server/database/postgres.go#L277-L312)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable key used in defer or goroutine at line 302

[Click here to see the code in its original context.](https://github.com/ASeegull/SmartFridge/blob/5154e44b87d5023ed26c645001b696b1212baebc/server/database/postgres.go#L277-L312)

Click here to show the 36 line(s) of Go which triggered the analyzer.

```go
for key, recipe := range recipes {
wg.Add(1)
go func(wg *sync.WaitGroup, index int, recipe Recepie) {
var name, unit string
var amount int

defer wg.Done()

rows, err := db.Table("recepies").Select("ingridients.amount, m_units.unit, products.name").
Joins("LEFT JOIN ingridients on ingridients.recipe_id = recepies.id").
Joins("JOIN products on ingridients.product_id = products.id").
Joins("JOIN m_units on m_units.id = products.units").
Where("recepies.id=?", recipe.ID).
Rows()
if err != nil {
return
}
defer rows.Close()
for rows.Next() {
err := rows.Scan(&amount, &unit, &name)
if err != nil {
return
}
if contains(productNameSlice, name) && amount <= productMap[name] {
mu.Lock()
recipes[key].Ingred = append(recipes[key].Ingred, strconv.Itoa(amount)+" "+unit+" "+name)
mu.Unlock()
} else {
return
}
}
mu.Lock()
copyRec = append(copyRec, recipes[key])
mu.Unlock()
}(wg, key, recipe)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 5154e44b87d5023ed26c645001b696b1212baebc

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.