github-vet / github-vet/rangeloop-pointer-findings

Gimulator/hub: controllers/ml/ml_controller.go; 14 LoC

Open
#13,281 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Gimulator/hub](https://www.github.com/Gimulator/hub) at [controllers/ml/ml_controller.go](https://github.com/Gimulator/hub/blob/e75b820d5098ce23976027034fab430bc0e7b37a/controllers/ml/ml_controller.go#L601-L614)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to ml was used in a composite literal at line 607

[Click here to see the code in its original context.](https://github.com/Gimulator/hub/blob/e75b820d5098ce23976027034fab430bc0e7b37a/controllers/ml/ml_controller.go#L601-L614)

Click here to show the 14 line(s) of Go which triggered the analyzer.

```go
for _, ml := range mls.Items {
if ml.Status.StatusType != mlv1.MLStatusTypePending || ml.CreationTimestamp.IsZero() {
continue
}

if candidateML == nil {
candidateML = &ml
continue
}

if candidateML.CreationTimestamp.After(ml.CreationTimestamp.Time) {
candidateML = &ml
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e75b820d5098ce23976027034fab430bc0e7b37a

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect controllers/ml/ml_controller.go around lines 601-614 at commit e75b820d5098ce23976027034fab430bc0e7b37a, starting with the analyzer's range-loop pointer finding. Determine whether taking a reference to ml affects the controller's behavior, then leave the requested reaction classifying it as a bug, mitigated, or desirable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.