github-vet / github-vet/rangeloop-pointer-findings

redhat-marketplace/redhat-marketplace-operator: pkg/apis/marketplace/v1alpha1/zz_generated.deepcopy.go; 13 LoC

Open
#13,278 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [redhat-marketplace/redhat-marketplace-operator](https://www.github.com/redhat-marketplace/redhat-marketplace-operator) at [pkg/apis/marketplace/v1alpha1/zz_generated.deepcopy.go](https://github.com/redhat-marketplace/redhat-marketplace-operator/blob/1265df5cfdbb200c5c6c80d5442069c13bb2c76c/pkg/apis/marketplace/v1alpha1/zz_generated.deepcopy.go#L785-L797)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 790

[Click here to see the code in its original context.](https://github.com/redhat-marketplace/redhat-marketplace-operator/blob/1265df5cfdbb200c5c6c80d5442069c13bb2c76c/pkg/apis/marketplace/v1alpha1/zz_generated.deepcopy.go#L785-L797)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal map[string]string
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(Header, len(*in))
for key, val := range *in {
(*out)[key] = val
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1265df5cfdbb200c5c6c80d5442069c13bb2c76c

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading pkg/apis/marketplace/v1alpha1/zz_generated.deepcopy.go around lines 785-797 at commit 1265df5cfdbb200c5c6c80d5442069c13bb2c76c. Compare the analyzer's warning about the reassigned range variable with the surrounding generated code, then classify the finding as Bug, Mitigated, or Desirable Behavior using the project's stated definitions.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.