github-vet / github-vet/rangeloop-pointer-findings
incognitochain/incognito-chain: blockchain/txviewpoint.go; 31 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [incognitochain/incognito-chain](https://www.github.com/incognitochain/incognito-chain) at [blockchain/txviewpoint.go](https://github.com/incognitochain/incognito-chain/blob/ee0d43300569521e8a0ed41f44d03a06a3bfaa2a/blockchain/txviewpoint.go#L296-L326)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to outputCoin is reassigned at line 297
[Click here to see the code in its original context.](https://github.com/incognitochain/incognito-chain/blob/ee0d43300569521e8a0ed41f44d03a06a3bfaa2a/blockchain/txviewpoint.go#L296-L326)
Click here to show the 31 line(s) of Go which triggered the analyzer.
```go
for _, outputCoin := range outputCoins {
item := &outputCoin
commitment := item.CoinDetails.GetCoinCommitment().ToBytesS()
pubkey := item.CoinDetails.GetPublicKey().ToBytesS()
pubkeyStr := base58.Base58Check{}.Encode(pubkey, common.ZeroByte)
ok, err := statedb.HasCommitment(stateDB, *tokenID, commitment, shardID)
if err != nil {
return acceptedCommitments, acceptedOutputcoins, acceptedSnD, err
}
if !ok {
pubkeyStr := base58.Base58Check{}.Encode(pubkey, common.ZeroByte)
if acceptedCommitments[pubkeyStr] == nil {
acceptedCommitments[pubkeyStr] = make([][]byte, 0)
}
// get data for commitments
acceptedCommitments[pubkeyStr] = append(acceptedCommitments[pubkeyStr], item.CoinDetails.GetCoinCommitment().ToBytesS())
// get data for output coin
if acceptedOutputcoins[pubkeyStr] == nil {
acceptedOutputcoins[pubkeyStr] = make([]privacy.OutputCoin, 0)
}
acceptedOutputcoins[pubkeyStr] = append(acceptedOutputcoins[pubkeyStr], *item)
}
// get data for Snderivators
snD := item.CoinDetails.GetSNDerivator()
ok, err = statedb.HasSNDerivator(stateDB, *tokenID, snD.ToBytesS())
if !ok && err == nil {
acceptedSnD[pubkeyStr] = append(acceptedSnD[pubkeyStr], *snD)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ee0d43300569521e8a0ed41f44d03a06a3bfaa2a
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.