github-vet / github-vet/rangeloop-pointer-findings

doron-cohen/antidot: cmd/clean.go; 19 LoC

Open
#13,241 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [doron-cohen/antidot](https://www.github.com/doron-cohen/antidot) at [cmd/clean.go](https://github.com/doron-cohen/antidot/blob/8671d73a439110b749b25d75aa8905b8eb5057ed/cmd/clean.go#L45-L63)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to dotfile was used in a composite literal at line 46

[Click here to see the code in its original context.](https://github.com/doron-cohen/antidot/blob/8671d73a439110b749b25d75aa8905b8eb5057ed/cmd/clean.go#L45-L63)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for _, dotfile := range dotfiles {
rule := rules.MatchRule(&dotfile)
if rule == nil {
continue
}

rule.Pprint()
if rule.Ignore {
continue
}

confirmed := tui.Confirm(fmt.Sprintf("Apply rule %s?", rule.Name))
if confirmed {
rule.Apply()
appliedRule = true
}

tui.Print("") // one line space
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 8671d73a439110b749b25d75aa8905b8eb5057ed

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.