github-vet / github-vet/rangeloop-pointer-findings
milQA/hw2: signer.go; 24 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [milQA/hw2](https://www.github.com/milQA/hw2) at [signer.go](https://github.com/milQA/hw2/blob/f33c8e90934e8418e55c48cfa54e8de33db933cc/signer.go#L33-L56)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable input used in defer or goroutine at line 39
[Click here to see the code in its original context.](https://github.com/milQA/hw2/blob/f33c8e90934e8418e55c48cfa54e8de33db933cc/signer.go#L33-L56)
Click here to show the 24 line(s) of Go which triggered the analyzer.
```go
for input := range in {
mu2.Lock()
wg.Add(1)
go func(wg *sync.WaitGroup) {
ch2 := make(chan string)
ch3 := make(chan string)
datain := input.(int)
data := strconv.Itoa(datain)
mu.Lock()
md5data := DataSignerMd5(data)
mu.Unlock()
go fcrc32(ch2, md5data)
go fcrc32(ch3, data)
result1 := <-ch3
result2 := <-ch2
result := result1 + "~" + result2
out <- result
wg.Done()
}(wg)
mu2.Unlock()
runtime.Gosched()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: f33c8e90934e8418e55c48cfa54e8de33db933cc
Contributor guide
No contributing guide indexed for this repository
Research direction
Read signer.go lines 33-56 at commit f33c8e90934e8418e55c48cfa54e8de33db933cc and inspect how the range-loop variable is captured by the goroutine. Decide whether the finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on this issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100