chengyanfeng/egg_backend: controller/goldCoin.go; 34 LoC

Found a possible issue in [chengyanfeng/egg_backend](https://www.github.com/chengyanfeng/egg_backend) at [controller/goldCoin.go](https://github.com/chengyanfeng/egg_backend/blob/9fb11e689aa379cd43647e0a082e275e48bda15b/controller/goldCoin.go#L333-L366)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/chengyanfeng/egg_backend/blob/9fb11e689aa379cd43647e0a082e275e48bda15b/controller/goldCoin.go#L333-L366)

Click here to show the 34 line(s) of Go which triggered the analyzer.

```go
for k, v := range egg {
if k%30 == 29 {
//如果满30个
v.Sell = 1
//更新状态，标记已经售卖，或者兑换
models.DB.Model(&v).Update("Sell")
//个人资产鸡蛋减少一个
userProperty.RealEggs = userProperty.RealEggs - 1
models.DB.Model(&userProperty).Update("RealEggs")
//添加邮寄信息
eggTakenOrder := models.EggTakenOrder{}
eggTakenOrder.UserID = util.ToInt(userid)
eggTakenOrder.State = 1
eggTakenOrder.CreateTime = util.ToInt(time.Now().Unix())
eggTakenOrder.Amount = 30
eggTakenOrder.DeliverInfo = "xxx"
user := models.User{}
user.ID = util.ToInt(userid)
models.DB.First(&user)
eggTakenOrder.Address = user.AddressInfo
models.DB.Create(&eggTakenOrder)
if k == util.ToInt(realEgg)-1 {
break
}

} else {
v.Sell = 1
//更新状态，标记已经售卖，或者兑换
models.DB.Model(&v).Update("Sell")
//个人资产鸡蛋减少一个
userProperty.RealEggs = userProperty.RealEggs - 1
models.DB.Model(&userProperty).Update("RealEggs")
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Model 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 9fb11e689aa379cd43647e0a082e275e48bda15b

Open controller/goldCoin.go at lines 333-366 and read the surrounding function and range-loop behavior in Go. Check whether taking a pointer to the loop variable causes the database updates to affect the intended egg record, then leave the reaction that best classifies the finding as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.