github-vet / github-vet/rangeloop-pointer-findings

chengyanfeng/egg_backend: controller/goldCoin.go; 33 LoC

Open
#13,223 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [chengyanfeng/egg_backend](https://www.github.com/chengyanfeng/egg_backend) at [controller/goldCoin.go](https://github.com/chengyanfeng/egg_backend/blob/9fb11e689aa379cd43647e0a082e275e48bda15b/controller/goldCoin.go#L221-L253)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/chengyanfeng/egg_backend/blob/9fb11e689aa379cd43647e0a082e275e48bda15b/controller/goldCoin.go#L221-L253)

Click here to show the 33 line(s) of Go which triggered the analyzer.

```go
for k, v := range egg {
if k%3 == 2 {
//如果满三次,那就换成鸡蛋
v.Sell = 1
//更新状态,标记已经售卖,或者兑换
models.DB.Model(&v).Update("Sell")
//换成鸡蛋
egg := models.Egg{}
egg.Sell = 0
egg.CreateTimeDay = util.GetCurDayTime()
egg.CreateTime = util.ToInt(time.Now().Unix())
egg.UserId = util.ToInt(userid)
egg.Type = 2
egg.Source = 2

//个人资产彩蛋减少一个,鸡蛋添加一个
userProperty.FreeEggs = userProperty.FreeEggs - 1
userProperty.RealEggs = userProperty.RealEggs + 1
models.DB.Model(&userProperty).Update("FreeEggs", "RealEggs")

if k == util.ToInt(redEgg)-1 {
break
}

} else {
v.Sell = 1
//更新状态,标记已经售卖,或者兑换
models.DB.Model(&v).Update("Sell")
//个人资产彩蛋减少一个
userProperty.FreeEggs = userProperty.FreeEggs - 1
models.DB.Model(&userProperty).Update("FreeEggs")
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Model 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 9fb11e689aa379cd43647e0a082e275e48bda15b

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with controller/goldCoin.go at lines 221-253 and inspect the surrounding controller entry point and models.DB updates. Determine whether the analyzer's range-loop finding affects the records being updated, then check any relevant project tests or callers. Done means establishing whether this is a bug, mitigated, or desirable behavior and leaving the corresponding classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.