github-vet / github-vet/rangeloop-pointer-findings
TonyChG/libgen-cli: cmd/libgen-cli/download_all.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [TonyChG/libgen-cli](https://www.github.com/TonyChG/libgen-cli) at [cmd/libgen-cli/download_all.go](https://github.com/TonyChG/libgen-cli/blob/745a67232ca696f6d69d2a73cf718306403a9166/cmd/libgen-cli/download_all.go#L86-L99)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable book used in defer or goroutine at line 95
[Click here to see the code in its original context.](https://github.com/TonyChG/libgen-cli/blob/745a67232ca696f6d69d2a73cf718306403a9166/cmd/libgen-cli/download_all.go#L86-L99)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for _, book := range books {
if err := libgen.GetDownloadURL(book); err != nil {
fmt.Printf("error getting download DownloadURL: %v\n", err)
continue
}
wg.Add(1)
bChan <- book
go func() {
if err := libgen.DownloadBook(<-bChan, output); err != nil {
fmt.Printf("error downloading %v: %v\n", book.Title, err)
}
wg.Done()
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 745a67232ca696f6d69d2a73cf718306403a9166
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.