github-vet / github-vet/rangeloop-pointer-findings
UltimateCryptoExtreme/ucebot: main.go; 16 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [UltimateCryptoExtreme/ucebot](https://www.github.com/UltimateCryptoExtreme/ucebot) at [main.go](https://github.com/UltimateCryptoExtreme/ucebot/blob/0f504d71448414b903251ebab0b9b2dbc171fe5a/main.go#L114-L129)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable e used in defer or goroutine at line 122
[Click here to see the code in its original context.](https://github.com/UltimateCryptoExtreme/ucebot/blob/0f504d71448414b903251ebab0b9b2dbc171fe5a/main.go#L114-L129)
Click here to show the 16 line(s) of Go which triggered the analyzer.
```go
for _, e := range exchanges {
ps, ok := e.(PriceSource)
if !ok {
log.Printf("Exchange %s can not be used for fetching prices.", e.Name())
continue
}
wg.Add(1)
go func() {
if p, err := ps.Price(e.CurrencyMarket(market)); err == nil {
pc <- p
} else {
log.Printf("%v", err)
}
wg.Done()
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 0f504d71448414b903251ebab0b9b2dbc171fe5a
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect main.go lines 114-129 in the referenced ucebot commit, beginning with the range loop and its goroutine. Check the surrounding code and the linked project context to determine whether the reported capture is a real bug, mitigated, or desirable behavior. When decided, leave the corresponding reaction on this issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100