github-vet / github-vet/rangeloop-pointer-findings
open-o11y/opentelemetry-collector-testing: consumer/pdata/generated_metrics.go; 4 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [open-o11y/opentelemetry-collector-testing](https://www.github.com/open-o11y/opentelemetry-collector-testing) at [consumer/pdata/generated_metrics.go](https://github.com/open-o11y/opentelemetry-collector-testing/blob/85737fa2be57216857202671e9f056f9b39364db/consumer/pdata/generated_metrics.go#L292-L295)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 294 may store a reference to el
[Click here to see the code in its original context.](https://github.com/open-o11y/opentelemetry-collector-testing/blob/85737fa2be57216857202671e9f056f9b39364db/consumer/pdata/generated_metrics.go#L292-L295)
Click here to show the 4 line(s) of Go which triggered the analyzer.
```go
for i, el := range *es.orig {
wrappers[i] = &origs[i]
newInstrumentationLibraryMetrics(&el).CopyTo(newInstrumentationLibraryMetrics(&wrappers[i]))
}
```
Click here to show extra information the analyzer produced.
```
The following graphviz dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
digraph G {
"(newInstrumentationLibraryMetrics, 1)" -> {}
}
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 85737fa2be57216857202671e9f056f9b39364db
Contributor guide
No contributing guide indexed for this repository
Research direction
Read consumer/pdata/generated_metrics.go at lines 292-295 and review the linked analyzer report about the range-loop variable reference. Decide whether this instance is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability-sre
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100