github-vet / github-vet/rangeloop-pointer-findings

gridgentoo/UberCadence: common/persistence/sql/workflowStateMaps.go; 25 LoC

Open
#13,095 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gridgentoo/UberCadence](https://www.github.com/gridgentoo/UberCadence) at [common/persistence/sql/workflowStateMaps.go](https://github.com/gridgentoo/UberCadence/blob/728d1a07293d66a78f4bc3427108704190a4b4de/common/persistence/sql/workflowStateMaps.go#L271-L295)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to v was used in a composite literal at line 277

[Click here to see the code in its original context.](https://github.com/gridgentoo/UberCadence/blob/728d1a07293d66a78f4bc3427108704190a4b4de/common/persistence/sql/workflowStateMaps.go#L271-L295)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for _, v := range deleteInfos {
result, err := tx.DeleteFromTimerInfoMaps(&sqlplugin.TimerInfoMapsFilter{
ShardID: int64(shardID),
DomainID: domainID,
WorkflowID: workflowID,
RunID: runID,
TimerID: &v,
})
if err != nil {
return &workflow.InternalServiceError{
Message: fmt.Sprintf("Failed to update timer info. Failed to execute delete query. Error: %v", err),
}
}
rowsAffected, err := result.RowsAffected()
if err != nil {
return &workflow.InternalServiceError{
Message: fmt.Sprintf("Failed to update timer info. Failed to verify number of rows deleted. Error: %v", err),
}
}
if int(rowsAffected) != 1 {
return &workflow.InternalServiceError{
Message: fmt.Sprintf("Failed to update timer info. Deleted %v rows instead of 1", rowsAffected),
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 728d1a07293d66a78f4bc3427108704190a4b4de

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in common/persistence/sql/workflowStateMaps.go at lines 271-295 and inspect the deleteInfos range loop, especially the TimerID reference passed to DeleteFromTimerInfoMaps. Determine whether the analyzer finding can affect which timer is deleted; done means the behavior is understood and the issue is classified as a bug, mitigated, or desirable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.