github-vet / github-vet/rangeloop-pointer-findings

NetApp/trident: operator/controllers/provisioner/installer/installer.go; 15 LoC

Open
#13,032 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [NetApp/trident](https://www.github.com/NetApp/trident) at [operator/controllers/provisioner/installer/installer.go](https://github.com/NetApp/trident/blob/62ab24d23195b6616334fb7d17fe4a629dda67fe/operator/controllers/provisioner/installer/installer.go#L932-L946)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to clusterRole is reassigned at line 937

[Click here to see the code in its original context.](https://github.com/NetApp/trident/blob/62ab24d23195b6616334fb7d17fe4a629dda67fe/operator/controllers/provisioner/installer/installer.go#L932-L946)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for _, clusterRole := range clusterRoles {
if clusterRole.Name == clusterRoleName {
// Found a cluster role named trident/trident-csi
log.Infof("A Trident cluster role named '%s' was found by label.", clusterRoleName)

currentClusterRole = &clusterRole
createClusterRole = false
} else {
log.Errorf("a Trident cluster role %s was found by label "+
"but does not meet name '%s' requirement, marking it for deletion",
clusterRole.Name, clusterRoleName)

unwantedClusterRoles = append(unwantedClusterRoles, clusterRole)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 62ab24d23195b6616334fb7d17fe4a629dda67fe

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.