github-vet / github-vet/rangeloop-pointer-findings

NetApp/trident: operator/controllers/provisioner/installer/installer.go; 15 LoC

Open
#13,031 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [NetApp/trident](https://www.github.com/NetApp/trident) at [operator/controllers/provisioner/installer/installer.go](https://github.com/NetApp/trident/blob/62ab24d23195b6616334fb7d17fe4a629dda67fe/operator/controllers/provisioner/installer/installer.go#L1170-L1184)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to psp is reassigned at line 1175

[Click here to see the code in its original context.](https://github.com/NetApp/trident/blob/62ab24d23195b6616334fb7d17fe4a629dda67fe/operator/controllers/provisioner/installer/installer.go#L1170-L1184)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for _, psp := range podSecurityPolicies {
if psp.Name == pspName {
// Found a pod security policy named tridentpods
log.Infof("A Trident Pod security policy named '%s' was found by label.", pspName)

currentPSP = &psp
createPSP = false
} else {
log.Errorf("a Trident Pod security policy %s was found by label "+
"but does not meet name '%s' requirement, marking it for deletion",
psp.Name, pspName)

unwantedPSPs = append(unwantedPSPs, psp)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 62ab24d23195b6616334fb7d17fe4a629dda67fe

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with operator/controllers/provisioner/installer/installer.go around lines 1170-1184 and review the reported range-loop pointer finding in the shown snippet. Check the relevant Go range-loop behavior, then determine whether the finding is a Bug, Mitigated, or Desirable Behavior and leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.