github-vet / github-vet/rangeloop-pointer-findings

NetApp/trident: storage_drivers/aws/aws_cvs.go; 15 LoC

Open
#13,021 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [NetApp/trident](https://www.github.com/NetApp/trident) at [storage_drivers/aws/aws_cvs.go](https://github.com/NetApp/trident/blob/62ab24d23195b6616334fb7d17fe4a629dda67fe/storage_drivers/aws/aws_cvs.go#L1604-L1618)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to volume was used in a composite literal at line 1617

[Click here to see the code in its original context.](https://github.com/NetApp/trident/blob/62ab24d23195b6616334fb7d17fe4a629dda67fe/storage_drivers/aws/aws_cvs.go#L1604-L1618)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for _, volume := range *volumes {

// Filter out volumes in an unavailable state
switch volume.LifeCycleState {
case api.StateDisabled, api.StateDeleting, api.StateDeleted, api.StateError:
continue
}

// Filter out volumes without the prefix (pass all if prefix is empty)
if !strings.HasPrefix(volume.CreationToken, prefix) {
continue
}

channel <- &storage.VolumeExternalWrapper{Volume: d.getVolumeExternal(&volume), Error: nil}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 62ab24d23195b6616334fb7d17fe4a629dda67fe

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with storage_drivers/aws/aws_cvs.go lines 1604-1618 and inspect how getVolumeExternal receives the range-loop volume. Determine whether the referenced volume can be reused across iterations, then review the analyzer’s classification guidance. Done means reacting to the issue as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.