github-vet / github-vet/rangeloop-pointer-findings

duniter/WotWizard: src/util/graphQL/graphQL.go; 22 LoC

Open
#13,006 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [duniter/WotWizard](https://www.github.com/duniter/WotWizard) at [src/util/graphQL/graphQL.go](https://github.com/duniter/WotWizard/blob/fa3ac5b2a4501b5ad1550eb43576a376bf7c1b69/src/util/graphQL/graphQL.go#L3850-L3871)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to ai is reassigned at line 3856

[Click here to see the code in its original context.](https://github.com/duniter/WotWizard/blob/fa3ac5b2a4501b5ad1550eb43576a376bf7c1b69/src/util/graphQL/graphQL.go#L3850-L3871)

Click here to show the 22 line(s) of Go which triggered the analyzer.

```go
for _, ai := range as {
name := ai.Name
ok := false
for _, di := range ds {
if di.Name.S == name.S {
ok = true
a = &ai
d = di
break
}
}
if !ok {
ts.Error("IsNotInputFieldFor", name.S, parentName.S, name.P, nil)
} else {
ValidateArgument(a, d.DefVal, d.Type, vd)
}
if set != nil {
if _, found, _ := set.SearchIns(&NameMapItem{name}); found {
ts.Error("DupArgName", name.S, "", name.P, nil)
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: fa3ac5b2a4501b5ad1550eb43576a376bf7c1b69

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.