github-vet / github-vet/rangeloop-pointer-findings

containerum/chkit: pkg/controls/container/env.go; 3 LoC

Open
#12,996 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [containerum/chkit](https://www.github.com/containerum/chkit) at [pkg/controls/container/env.go](https://github.com/containerum/chkit/blob/e46faf218be7797f1a686aa1135e4d4c0885fb65/pkg/controls/container/env.go#L24-L26)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to env was used in a composite literal at line 25

[Click here to see the code in its original context.](https://github.com/containerum/chkit/blob/e46faf218be7797f1a686aa1135e4d4c0885fb65/pkg/controls/container/env.go#L24-L26)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, env := range envs {
menuEnvs = append(menuEnvs, componentEnv(&env, nil))
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e46faf218be7797f1a686aa1135e4d4c0885fb65

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at pkg/controls/container/env.go lines 24-26 and inspect the analyzer warning about referencing env in the composite literal. Verify whether the range-loop reference can produce incorrect menuEnvs entries, then check the surrounding container-control code for the intended behavior. Done means the warning is addressed without changing the intended environment handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.