github-vet / github-vet/rangeloop-pointer-findings
arangodb/kube-arangodb: pkg/util/k8sutil/annotations.go; 5 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [arangodb/kube-arangodb](https://www.github.com/arangodb/kube-arangodb) at [pkg/util/k8sutil/annotations.go](https://github.com/arangodb/kube-arangodb/blob/9cbbec404f34463db55e29ebb7f5dbb8aa35d984/pkg/util/k8sutil/annotations.go#L177-L181)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/arangodb/kube-arangodb/blob/9cbbec404f34463db55e29ebb7f5dbb8aa35d984/pkg/util/k8sutil/annotations.go#L177-L181)
Click here to show the 5 line(s) of Go which triggered the analyzer.
```go
for _, serviceAccount := range serviceAccounts.Items {
if IsChildResource(kind, name, namespace, &serviceAccount) {
childServiceAccounts = append(childServiceAccounts, serviceAccount.DeepCopy())
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {IsChildResource 4} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 9cbbec404f34463db55e29ebb7f5dbb8aa35d984
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in pkg/util/k8sutil/annotations.go at lines 177-181 and read IsChildResource plus the surrounding service-account handling. Trace whether the range variable or its DeepCopy result can escape incorrectly, then classify the analyzer finding as a bug, mitigated, or desirable behavior; done means the classification is supported by the code's actual behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100