jerrinsg/go-pmem: src/cmd/compile/internal/ssa/compile.go; 61 LoC

Found a possible issue in [jerrinsg/go-pmem](https://www.github.com/jerrinsg/go-pmem) at [src/cmd/compile/internal/ssa/compile.go](https://github.com/jerrinsg/go-pmem/blob/35da56fed65ecec7fce3310d537b250238d3c1a8/src/cmd/compile/internal/ssa/compile.go#L58-L118)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to p is reassigned at line 62

[Click here to see the code in its original context.](https://github.com/jerrinsg/go-pmem/blob/35da56fed65ecec7fce3310d537b250238d3c1a8/src/cmd/compile/internal/ssa/compile.go#L58-L118)

Click here to show the 61 line(s) of Go which triggered the analyzer.

```go
for _, p := range passes {
if !f.Config.optimize && !p.required || p.disabled {
continue
}
f.pass = &p
phaseName = p.name
if f.Log() {
f.Logf(" pass %s begin\n", p.name)
}
// TODO: capture logging during this pass, add it to the HTML
var mStart runtime.MemStats
if logMemStats || p.mem {
runtime.ReadMemStats(&mStart)
}

tStart := time.Now()
p.fn(f)
tEnd := time.Now()

// Need something less crude than "Log the whole intermediate result".
if f.Log() || f.HTMLWriter != nil {
time := tEnd.Sub(tStart).Nanoseconds()
var stats string
if logMemStats {
var mEnd runtime.MemStats
runtime.ReadMemStats(&mEnd)
nBytes := mEnd.TotalAlloc - mStart.TotalAlloc
nAllocs := mEnd.Mallocs - mStart.Mallocs
stats = fmt.Sprintf("[%d ns %d allocs %d bytes]", time, nAllocs, nBytes)
} else {
stats = fmt.Sprintf("[%d ns]", time)
}

if f.Log() {
f.Logf(" pass %s end %s\n", p.name, stats)
printFunc(f)
}
f.HTMLWriter.WriteFunc(phaseName, fmt.Sprintf("%s %s", phaseName, stats), f)
}
if p.time || p.mem {
// Surround timing information w/ enough context to allow comparisons.
time := tEnd.Sub(tStart).Nanoseconds()
if p.time {
f.LogStat("TIME(ns)", time)
}
if p.mem {
var mEnd runtime.MemStats
runtime.ReadMemStats(&mEnd)
nBytes := mEnd.TotalAlloc - mStart.TotalAlloc
nAllocs := mEnd.Mallocs - mStart.Mallocs
f.LogStat("TIME(ns):BYTES:ALLOCS", time, nBytes, nAllocs)
}
}
if p.dump != nil && p.dump[f.Name] {
// Dump function to appropriately named file
f.dumpFile(phaseName)
}
if checkEnabled {
checkFunc(f)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 35da56fed65ecec7fce3310d537b250238d3c1a8

Read src/cmd/compile/internal/ssa/compile.go around lines 58-118, focusing on the range loop and the reference to p reported at line 62. Determine whether the reassignment is a real range-loop pointer issue or expected behavior in this compiler code. The issue is complete when the finding is classified as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.